-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Shared: Apply ShowProvenance
in InlineFlowTest.qll
#17173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7de0b67
to
11adf75
Compare
45a1ef4
to
bf64a69
Compare
bf64a69
to
fb0ad9c
Compare
The references to ProvenancePathGraph in places where it shouldn't be relevant aren't that nice, so I've made a refactoring that unifies the two |
fb0ad9c
to
4ce9c0d
Compare
michaelnebel
previously approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C# LGTM
aschackmull
reviewed
Aug 13, 2024
java/ql/src/Security/CWE/CWE-200/TempDirLocalInformationDisclosure.ql
Outdated
Show resolved
Hide resolved
4ce9c0d
to
69b581c
Compare
aschackmull
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C#
DataFlow Library
Go
Java
JS
Kotlin
no-change-note-required
This PR does not need a change note
Python
Ruby
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply
ShowProvenance
inInlineFlowTest.qll
in order to replace internalQlBuiltins::ExtensionId
values with references to the actual Models-as-Data rows.