Skip to content

Shared: Apply ShowProvenance in InlineFlowTest.qll #17173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Aug 7, 2024

Apply ShowProvenance in InlineFlowTest.qll in order to replace internal QlBuiltins::ExtensionId values with references to the actual Models-as-Data rows.

@hvitved hvitved force-pushed the shared/inline-flow-provenance branch from 7de0b67 to 11adf75 Compare August 7, 2024 11:19
@hvitved hvitved force-pushed the shared/inline-flow-provenance branch 3 times, most recently from 45a1ef4 to bf64a69 Compare August 7, 2024 13:07
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Aug 8, 2024
@hvitved hvitved marked this pull request as ready for review August 8, 2024 07:20
@hvitved hvitved requested review from a team as code owners August 8, 2024 07:20
@hvitved hvitved force-pushed the shared/inline-flow-provenance branch from bf64a69 to fb0ad9c Compare August 9, 2024 11:59
@aschackmull
Copy link
Contributor

The references to ProvenancePathGraph in places where it shouldn't be relevant aren't that nice, so I've made a refactoring that unifies the two PathGraphSigs: #17201

@hvitved hvitved force-pushed the shared/inline-flow-provenance branch from fb0ad9c to 4ce9c0d Compare August 13, 2024 07:34
michaelnebel
michaelnebel previously approved these changes Aug 13, 2024
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# LGTM

@hvitved hvitved merged commit 51077ce into github:main Aug 13, 2024
55 of 57 checks passed
@hvitved hvitved deleted the shared/inline-flow-provenance branch August 13, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants