Kotlin: expose kotlin version picker for internal packaging #16731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criemen
approved these changes
Jun 13, 2024
| genrule( | ||
| name = "versions-list", | ||
| outs = ["kotlin-versions.list"], | ||
| cmd = "\n".join(["cat > $@ << EOF"] + VERSIONS + ["EOF"]), |
There was a problem hiding this comment.
Did we test this on Windows?
There was a problem hiding this comment.
bazel still uses bash for genrules on windows, but anyway I double checked and it indeed works.
There was a problem hiding this comment.
I know it does, but due to msys paths sometimes genrules on Windows still behave weirdly... better check to be safe!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal repository is still using
kotlin_plugin_versions.pyfor running QL tests, which we want to replace with versions specified inversions.bzl.This renames
kotlin_plugin_versions.pytopick-kotlin-version.py, and enhances it to accept a list of available versions to pick from. This functionality was moved from the Starlark implementation indeps.bzl. The list of versions (taken fromVERSIONSinversions.bzl) is now also exposed as akotlin-versions.listfile.After this we will be able to package these files into the distribution, so that they can be used for running QL tests.
Please refer to the internal PR linked below to see how this is used.