Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into releases/v3 #2854

Merged
merged 11 commits into from
Apr 7, 2025
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 7, 2025

Merging a35ae8c into releases/v3.

Conductor for this PR is @aeisenberg.

Contains the following pull requests:

Please do the following:

  • Ensure the CHANGELOG displays the correct version and date.
  • Ensure the CHANGELOG includes all relevant, user-facing changes since the last release.
  • Check that there are not any unexpected commits being merged into the releases/v3 branch.
  • Ensure the docs team is aware of any documentation changes that need to be released.
  • Mark the PR as ready for review to trigger the full set of PR checks.
  • Approve and merge this PR. Make sure Create a merge commit is selected rather than Squash and merge or Rebase and merge.
  • Merge the mergeback PR that will automatically be created once this PR is merged.
  • Merge all backport PRs to older release branches, that will automatically be created once this PR is merged.

henrymercer and others added 10 commits April 4, 2025 14:40
This commit updates the diff-range data extension to use the new
checkPresence field being introduced in CodeQL CLI 2.21.0, so that
diff-informed analysis no longer fails when a query pack does not have
the restrictAlertsTo extensible predicate.
Mergeback v3.28.14 refs/heads/releases/v3 into main
Raise the file limit for debug artifacts by producing zip64 files where necessary
Set checkPresence in diff-range data extension
@aeisenberg aeisenberg marked this pull request as ready for review April 7, 2025 21:15
@Copilot Copilot bot review requested due to automatic review settings April 7, 2025 21:15
@aeisenberg aeisenberg requested a review from a team as a code owner April 7, 2025 21:15
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges the latest changes from main into the releases/v3 branch, updating configuration values, replacing the zip creation library, and adding a new flag to the analyze extension. Key changes include:

  • Updating the minimum version for the DiffInformedQueries feature flag and removing the now-unused toolsFeature property.
  • Replacing AdmZip with archiver for creating debug artifact bundles.
  • Adding a new checkPresence flag to the analyze extension.

Reviewed Changes

Copilot reviewed 43 out of 44 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/feature-flags.ts Updated minimum version value and removed the toolsFeature property.
src/debug-artifacts.ts Switched from AdmZip to archiver for zip compression and added error events.
src/analyze.ts Added a new checkPresence flag in the extension configuration.
lib/feature-flags.js Mirror update to feature flags similar to src/feature-flags.ts.
lib/debug-artifacts.js Mirror switch to archiver for debug artifact bundling.
lib/analyze.js Mirror update to include the checkPresence flag.
CHANGELOG.md Added release notes for version 3.28.15.
Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (4)

src/feature-flags.ts:114

  • The removal of the 'toolsFeature' property may lead to unexpected behavior if downstream logic still relies on it. Verify that its removal is intentional and that any dependent code is updated accordingly.
    toolsFeature: ToolsFeature.DatabaseInterpretResultsSupportsSarifRunProperty,

lib/feature-flags.js:98

  • The removal of the 'toolsFeature' property here could affect behavior if any dependent usage exists. Confirm the removal is deliberate and adjust dependent logic if needed.
        toolsFeature: tools_features_1.ToolsFeature.DatabaseInterpretResultsSupportsSarifRunProperty,

src/debug-artifacts.ts:347

  • Consider adding or updating tests to verify the new error and warning handling behavior introduced with archiver.
const output = fs.createWriteStream(databaseBundlePath);

lib/debug-artifacts.js:253

  • Consider adding or updating tests to verify that the new archiver implementation properly handles errors and warnings, ensuring consistency with previous behavior.
const output = fs.createWriteStream(databaseBundlePath);

@aeisenberg aeisenberg merged commit 45775bd into releases/v3 Apr 7, 2025
533 checks passed
@aeisenberg aeisenberg deleted the update-v3.28.15-a35ae8c38 branch April 7, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants