-
Notifications
You must be signed in to change notification settings - Fork 15
feat: release on specific labels #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Related to github/github-ospo#105 Only generate a release and new action container images if our semver related labels (`breaking`, `enhancement`) or the `release` label are used on a merged pull request. Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch. This gives us access to the pull requests labels without having to make API cals. Currently we'd still need to label a pull request with `release` if it is a dependabot or manual pull request related to a CVE or security fix. - [x] update CONTRIBUTING.md with new release information - [x] manually add `vuln` and `release` labels to repository Signed-off-by: jmeridth <[email protected]>
@zkoppert how do you feel about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this should work for forks and not trigger for closed but not merged PRs. Looks great!
To me, |
Co-authored-by: Zack Koppert <[email protected]>
this will cause a release to happen immediately when a fix labelled PR is merged Signed-off-by: jmeridth <[email protected]>
@zkoppert |
Related to github/github-ospo#105
Pull Request
Proposed Changes
Only generate a release and new action container images if our semver related labels (
breaking
,enhancement
,fix
) or therelease
label are used on a merged pull request.Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch.
This gives us access to the pull requests labels without having to make API cals.
Currently we'd still need to label a pull request with
release
if it is a dependabot or manual pull request related to a CVE or security fix.vuln
andrelease
labels to repositoryReadiness Checklist
Author/Contributor
make lint
and fix any issues that you have introducedmake test
and ensure you have test coverage for the lines you are introducingReviewer
fix
,documentation
,enhancement
,infrastructure
,maintenance
orbreaking