feat: added missing launch template tag_specifications #4531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
requested changes
Apr 16, 2025
|
sorry messed up, creating a fresh PR |
npalm
added a commit
that referenced
this pull request
Apr 16, 2025
copy from #4531 Currently the launch template specification adds tags only on resource types of `instance` and `volume` this leaves the other 2 supported resource types (`spot-instances-request` and `network-interface`) untagged which by extensions does not produce accurate data on Cost Explorer. This pr fixes this by adding the missing `tag_specifications` configurations. --------- Co-authored-by: konkerama <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Currently the launch template specification adds tags only on resource types of
instanceandvolumethis leaves the other 2 supported resource types (spot-instances-requestandnetwork-interface) untagged which by extensions does not produce accurate data on Cost Explorer.This pr fixes this by adding the missing
tag_specificationsconfigurations.