Skip to content

chore(docs): make a note about subnet AZ uniqueness requirement #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

jpalomaki
Copy link
Contributor

With link to issue where this is discussed

@jpalomaki jpalomaki changed the title Make a note about subnet AZ uniqueness requirement chore: make a note about subnet AZ uniqueness requirement Jan 25, 2023
@jpalomaki jpalomaki changed the title chore: make a note about subnet AZ uniqueness requirement chore(docs): make a note about subnet AZ uniqueness requirement Jan 25, 2023
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable section in the REAMDE.md are generated based on the terraform varaibles.tf files. Please update the varaiable.tf file. The pre-commit hooks will update the README.

@npalm
Copy link
Member

npalm commented Feb 17, 2023

@jpalomaki did you had time to check the requested change?

@jpalomaki
Copy link
Contributor Author

@npalm No, not yet, been busy with other stuff and need to look into the precommit hook

@npalm npalm merged commit bbe22ab into github-aws-runners:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants