fix(nat): Make stateful NAT code direction-independent #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit b12d185 ("feat(nat): Make NAT stage direction-independant") we changed the way we're handling directions in NAT stages. That commit mostly focused on stateful NAT, and the sensitive code portions in the module for stateful NAT were simply commented out, given that the code is not complete anyway. Here we adjust the code for stateful NAT, on the same basis. We make it handle both source and destination NAT, in a single pipeline stage. This requires storing more information in the state tables, given that we need addresses and port for both directions. Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
added
dont-merge
|
I don't think this conflicts with #672. It doesn't touch the same files, the changes here do not rely on |
mvachhar
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit b12d185 we changed the way we're handling directions in NAT stages. That commit mostly focused on stateful NAT, and the sensitive code portions in the module for stateful NAT were simply commented out, given that the code is not complete anyway.
Here we adjust the code for stateful NAT, on the same basis. We make it handle both source and destination NAT, in a single pipeline stage. This requires storing more information in the state tables, given that we need addresses and port for both directions.