Support empty ips/as_range with non-empty nots/not_as
#662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user API supports VpcExpose configurations with empty "ips" (respectively "as_range") but non-empty "nots" (respectively "as_not"). To support this in the dataplane, we need to add a root prefix to the list of allowed prefixes when we optimise the expose object. Signed-off-by: Quentin Monnet <[email protected]>
This reverts commit e296c01. Following recent changes in the NAT code, in particular the removal of the "not" and "not_as" blocks from the internal NAT configuration object, we now support configuration with exclusion prefixes only, and can revert this commit where we rejected it during validation. Signed-off-by: Quentin Monnet <[email protected]>
Make sure that we process expose objects containing exclusion prefixes only as we expect. Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
force-pushed
the
pr/qmonnet/support-empty-allowed
branch
from
936ecd0 to
25e1799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress - blocked by #661