feat(nat): Use actual source-VPC VNI with NAT #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-noland
approved these changes
Jun 17, 2025
That discussion happened in the context of stateful NAT. I understand we probably want to use the same for stateless NAT as well, but the current implementation (for stateless) has been using the VNI from the beginning, and changing it to the VRF id is beyond the scope of the current PR (we'd need to change the stateless NAT tables to use the VRF id as a key rather than the VNI when we build the tables). I'll merge this, but create a ticket to track it. Thanks for the review! |
Based on Fredi's recent work to add the VNI from the source VPC to packet metadata, here's an update to the NAT code to read the VNI from metadata (rather than the hardcoded placeholder that we had). We also update unit tests accordingly. Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
force-pushed
the
pr/qmonnet/nat_vni_lookup
branch
from
4d58c00 to
2fd9636
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #598
Based on Fredi's recent work to add the VNI from the source VPC to packet metadata, here's an update to the NAT code to read the VNI from metadata (rather than the hardcoded placeholder that we had).
We also update unit tests accordingly.