Split gRPC converter into multiple files and remove convert_* functions #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move BGP functions to their own file. Also eliminate redundant convert_ functions and just use TryFrom. Signed-off-by: Manish Vachharajani <[email protected]>
Display was being used for CLI output. This creates a wrapper for that use case and implements a FromStr and Display that do the short form (so FromStr can parse Display) Signed-off-by: Manish Vachharajani <[email protected]>
This commit also uses a checked type for interface addresses Signed-off-by: Manish Vachharajani <[email protected]>
Signed-off-by: Manish Vachharajani <[email protected]>
Signed-off-by: Manish Vachharajani <[email protected]>
Signed-off-by: Manish Vachharajani <[email protected]>
Signed-off-by: Manish Vachharajani <[email protected]>
Signed-off-by: Manish Vachharajani <[email protected]>
Signed-off-by: Manish Vachharajani <[email protected]>
Signed-off-by: Manish Vachharajani <[email protected]>
Signed-off-by: Manish Vachharajani <[email protected]>
mvachhar
force-pushed
the
pr/mvachhar/mgmt-cleanup
branch
from
3fead95 to
6645af7
Compare
Signed-off-by: Manish Vachharajani <[email protected]>
mvachhar
force-pushed
the
pr/mvachhar/mgmt-cleanup
branch
from
6645af7 to
b13e054
Compare
qmonnet
approved these changes
Jun 6, 2025
| #[repr(transparent)] | ||
| pub struct RenderInterfaceAddress<'a>(pub &'a InterfaceAddress); | ||
|
|
||
| impl<'a> Display for RenderInterfaceAddress<'a> { |
| InvalidMaskLength(String), | ||
| } | ||
|
|
||
| impl FromStr for InterfaceAddress { |
There was a problem hiding this comment.
Also, why is this needed for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
convert_*functions in favor ofTryFromInterfaceAddresstypesPrefixis not the same asInterfaceAddresseven though both look like<ip addr>/<mask>as Prefix zeros the low order bits,InterfaceAddressdoes not. It may be the case that we should error parsing aPrefixthat does not already have the low order bits as 0 and error if theInterfaceAddressdoes have the low order bits as 0 (except for /31 and /127 masks) but I do not do that now as to limit the blast radius these changes.Fixes #549