fix(net): Fix build warnings (dead_code false positives) #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that rustc is not able to tell we're using MacTestStringGenerator and CommonHeaders through the .with_generator() method. Let's tell it to ignore dead code for these structs. Fixes: 613cf78 ("feat(net): Add Mac::try_from::<&str>()") Fixes: e1b8198 ("test(net): Add fuzz tests for parsing packet headers") Signed-off-by: Quentin Monnet <[email protected]>
|
If anyone can figure out why we failed to detect these in https://github.com/githedgehog/dataplane/actions/runs/15316095639/job/43090156535 before #536 was merged, I'm interested. The probability that |
This was referenced Jun 3, 2025
mvachhar
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Required to fix current CI failures on dev.yml with nightly toolchain
It seems that rustc is not able to tell we're using
MacTestStringGeneratorandCommonHeadersthrough the.with_generator()method. Let's tell it to ignore dead code for these structs.Fixes: 613cf78 ("feat(net): Add Mac::try_from::<&str>()")
Fixes: e1b8198 ("test(net): Add fuzz tests for parsing packet headers")