Some Cleanup of the gRPC converter code in mgmt #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the gRPC converter code in the mgmt module, improves error handling, and replaces manual indexing with Rust’s pattern matching. Key changes include the addition of clippy checks, refactoring of CIDR and interface conversion logic using pattern matching, and improved enum conversion via try_from.
Comment on lines
180
to
181
| .find(|vrf| vrf.name == "default") | ||
| .unwrap_or(&underlay.vrfs[0]); | ||
| .unwrap_or(&underlay.vrfs[0]); // FIXME(manish): This should be an error, preserving the original behavior for now | ||
|
|
There was a problem hiding this comment.
Consider returning an error when no default VRF is found instead of defaulting to underlay.vrfs[0], as the FIXME comment indicates that this behavior should be changed.
Copilot uses AI. Check for mistakes.
mvachhar
force-pushed
the
pr/smatov/advertise-networks
branch
2 times, most recently
from
3d5d341 to
6525541
Compare
mvachhar
force-pushed
the
pr/mvachhar/mgmt-cleanup
branch
2 times, most recently
from
a51dc03 to
72c1dd2
Compare
mvachhar
force-pushed
the
pr/smatov/advertise-networks
branch
from
3a46e5f to
a967446
Compare
mvachhar
force-pushed
the
pr/mvachhar/mgmt-cleanup
branch
from
72c1dd2 to
1659b57
Compare
mvachhar
force-pushed
the
pr/smatov/advertise-networks
branch
from
a967446 to
7572408
Compare
mvachhar
force-pushed
the
pr/mvachhar/mgmt-cleanup
branch
from
1659b57 to
537bf97
Compare
mvachhar
force-pushed
the
pr/smatov/advertise-networks
branch
from
7572408 to
1c50e2b
Compare
mvachhar
force-pushed
the
pr/mvachhar/mgmt-cleanup
branch
from
537bf97 to
23829f0
Compare
Silence clippy errors whose proper fix would require an interface change Signed-off-by: Manish Vachharajani <[email protected]>
Signed-off-by: Manish Vachharajani <[email protected]>
Rust pattern matching merges the length check with getting the entries. By using pattern matching there can be no error where the length does not match the dereference index leading to a runtime panic Signed-off-by: Manish Vachharajani <[email protected]>
mvachhar
force-pushed
the
pr/mvachhar/mgmt-cleanup
branch
from
23829f0 to
085e82a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started cleanup of the mgmt converter code.
I've added clippy checks and fixed issues, but not in a way that will change the interface.
I've removed all hard-coded constants
I've moved code to use Rust pattern matching instead of length checks + indexing for known-length vectors
There is still much more to do, but this is a good start at getting rid of some of the bigger issues.