NAT: Hook NAT table construction into mgmt
#529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
force-pushed
the
pr/qmonnet/nat-impl-peerings
branch
from
ff99e0b to
be6ff1a
Compare
qmonnet
force-pushed
the
pr/qmonnet/hook-nat-config
branch
from
520189b to
c8f212f
Compare
qmonnet
force-pushed
the
pr/qmonnet/nat-impl-peerings
branch
from
be6ff1a to
8a8ab31
Compare
qmonnet
force-pushed
the
pr/qmonnet/hook-nat-config
branch
from
c8f212f to
af212d0
Compare
qmonnet
force-pushed
the
pr/qmonnet/nat-impl-peerings
branch
from
8a8ab31 to
5a7b975
Compare
qmonnet
force-pushed
the
pr/qmonnet/hook-nat-config
branch
from
af212d0 to
2a35cb9
Compare
qmonnet
force-pushed
the
pr/qmonnet/nat-impl-peerings
branch
2 times, most recently
from
c16ccf0 to
9925bd2
Compare
qmonnet
force-pushed
the
pr/qmonnet/hook-nat-config
branch
from
2a35cb9 to
107ffcd
Compare
mvachhar
approved these changes
Jun 4, 2025
Inside of the NAT code, leverage the optimisation function to (potentially) reduce the number of prefixes and exclusion prefixes inside of the VpcExpose objects of a Peering before we process this Peering to extend the NAT tables. Now that we call the optimize_peering() function from add_peering(), make it private: it's unlikely we'll need to call it from somewhere else. Signed-off-by: Quentin Monnet <[email protected]>
We'll need the Clone trait for NatTables in a future commit to add NatTables as a member to a config object that needs to derive the trait. Signed-off-by: Quentin Monnet <[email protected]>
Make sure we create the NAT tables when building the internal configuration, and "store" them as part of the InternalConfig object. Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
force-pushed
the
pr/qmonnet/hook-nat-config
branch
from
107ffcd to
b52191c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #470
Fixes: #472