Skip to content

fix: drop search function on migration file #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: drop search function on migration file #55

merged 1 commit into from
Jan 20, 2025

Conversation

0xnigir1
Copy link
Collaborator

@0xnigir1 0xnigir1 commented Jan 17, 2025 •
edited
Loading

Description

Drop search function on migration

Checklist before requesting a review

  • I have conducted a self-review of my code.
  • I have conducted a QA.
  • If it is a core feature, I have included comprehensive tests.

@0xnigir1 0xnigir1 self-assigned this Jan 17, 2025
jahabeebs
jahabeebs approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@jahabeebs jahabeebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I wonder if for the other table drops if we should also add hasTable guards...not sure if Kysely throws an error for this if the table doesn't exist

@0xnigir1 0xnigir1 merged commit 652a772 into dev Jan 20, 2025
6 checks passed
@0xnigir1 0xnigir1 deleted the fix/migration-drop-function branch January 20, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahabeebs jahabeebs jahabeebs approved these changes

@0xkenj1 0xkenj1 0xkenj1 approved these changes

@0xyaco 0xyaco Awaiting requested review from 0xyaco

Assignees

@0xnigir1 0xnigir1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xnigir1 @jahabeebs @0xkenj1