-
Notifications
You must be signed in to change notification settings - Fork 1
chore: add managedBy terraform tag to all resources #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
0cc7124
to
d24de3b
Compare
📝 WalkthroughWalkthroughThe changes update several Terraform configuration files across different deployment environments by adding a new 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
⏰ Context from checks skipped due to timeout of 300000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
deployment/registry/main.tf (1)
3-8
: Enhanced Tagging with default_tags BlockThe new
default_tags
block correctly introduces the required tags (ManagedBy = "Terraform"
andAppName = "Indexer"
). This update will help with consistent resource identification across your deployment.deployment/environments/staging/main.tf (1)
13-20
: Default Tags Block with Minor Formatting InconsistencyThe tagging block is properly implemented, providing the expected
ManagedBy
andAppName
tags. However, note that the indentation for theAppName
key is slightly misaligned compared toManagedBy
. Consider adjusting the whitespace for improved readability and consistency across files.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
deployment/environments/production/main.tf
(1 hunks)deployment/environments/staging/main.tf
(1 hunks)deployment/registry/main.tf
(1 hunks)deployment/state/main.tf
(1 hunks)
⏰ Context from checks skipped due to timeout of 300000ms (1)
- GitHub Check: test / Unit and Integration Tests
🔇 Additional comments (2)
deployment/environments/production/main.tf (1)
13-18
: Consistent Default Tags ConfigurationThe
default_tags
block is added correctly within the AWS provider. It mirrors the tagging strategy from other environments, ensuring that resources are uniformly tagged.deployment/state/main.tf (1)
1-9
: Correct Default Tags Configuration in State ManagementThe addition of the
default_tags
block in the provider configuration is accurate and consistent with the other environment files. This ensures that AWS resources managed through state storage are properly tagged for easier management and tracking.
Summary by CodeRabbit