Skip to content

chore: fix celo token address and add G$ #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

chore: fix celo token address and add G$ #108

merged 1 commit into from
Mar 26, 2025

Conversation

thelostone-mc
Copy link
Contributor

@thelostone-mc thelostone-mc commented Mar 26, 2025

🤖 Linear

Closes PAR-XXX

Description

Checklist before requesting a review

  • I have conducted a self-review of my code.
  • I have conducted a QA.
  • If it is a core feature, I have included comprehensive tests.

Summary by CodeRabbit

  • New Features
    • Added a new token "G$" with updated attributes.
  • Refactor
    • Standardized token data by normalizing Ethereum address formatting.
    • Explicitly defined token decimals for enhanced consistency.

@thelostone-mc thelostone-mc marked this pull request as ready for review March 26, 2025 09:12
Copy link

coderabbitai bot commented Mar 26, 2025

📝 Walkthrough

Walkthrough

The changes update the token configuration by normalizing Ethereum addresses into a consistent checksum format. Specifically, the addresses for tokens such as "CUSD" and "USDGLO" are adjusted to use uppercase letters. Additionally, a new token entry for "G$" is introduced, which includes its address, token code, price source code, and decimals property. The USDGLO token entry is also modified to explicitly define its decimals value. The overall structure of the token definitions remains unchanged, with the modifications focusing on ensuring address consistency and completeness of token attributes.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5724ea6 and 49cdc9e.

📒 Files selected for processing (1)
  • packages/shared/src/tokens/tokens.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.ts`:

**/*.ts:

  • packages/shared/src/tokens/tokens.ts
⏰ Context from checks skipped due to timeout of 300000ms (1)
  • GitHub Check: e2e-tests / E2E Tests
🔇 Additional comments (3)
packages/shared/src/tokens/tokens.ts (3)

435-439: CUSD token address now properly checksummed.

The address format for the CUSD token has been updated to follow the checksumming requirement mentioned in the comment at line 43. This is a good change that improves consistency across token addresses.


441-446: USDGLO token address properly checksummed with explicit decimals.

The address for USDGLO token has been updated to follow the checksumming requirement. Additionally, the explicit definition of the decimals property improves clarity, even though this value (18) was likely already the default in the codebase.


447-452: Successfully added G$ token with proper formatting.

The new G$ token has been added with the correct structure, including a properly checksummed address, token code, price source code, and appropriate decimals value. This addition aligns with the PR objective of adding the G$ token.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@thelostone-mc thelostone-mc merged commit 0408b7a into dev Mar 26, 2025
8 checks passed
@thelostone-mc thelostone-mc deleted the celo-fix branch March 26, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant