-
Notifications
You must be signed in to change notification settings - Fork 3
chore: add fallback RPC #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe pull request updates configuration and documentation files for the indexer application. New RPC endpoints using environment variable fallbacks have been added or updated in the configuration file to support multiple blockchain networks including Mainnet, Optimism, Lukso, Gnosis, Polygon, Fantom, Zksync Era, Metis, Base, Arbitrum, Avalanche, Celo, Scroll, and Sepolia. The Dockerfile now installs the latest version of Corepack globally and introduces minor formatting improvements. Additionally, a new 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.env.example (1)
30-30
: Clarify the placeholder value forENVIO_ALCHEMY_API_KEY
.The new environment variable is added as a generic placeholder (
ALCHEMY_API_KEY
), which is consistent with the naming convention. For enhanced clarity, consider updating the placeholder to something more descriptive, for exampleYOUR_ALCHEMY_API_KEY_HERE
, and/or add an inline comment that instructs users to replace it with their actual Alchemy API key.
daa4e57
to
568c1f9
Compare
568c1f9
to
82469c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/indexer/README.md (1)
73-73
: Enhance Fallback RPC Note ClarityThe newly added note clearly communicates the importance of providing a fallback RPC given Hypersync's potential unreliability. It also thoughtfully directs users to check the
.env.example
file to ensure that all necessary environment variables are set before deployment.While the note is concise and on point, you might consider adding a brief explanation of what issues could arise when Hypersync fails (or a link to further documentation) to assist users who may be less familiar with the concept of fallback RPCs. This minor addition could further improve clarity and usefulness.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
Dockerfile
(1 hunks)apps/indexer/.env.example
(1 hunks)apps/indexer/README.md
(1 hunks)apps/indexer/config.yaml
(11 hunks)
✅ Files skipped from review due to trivial changes (1)
- apps/indexer/.env.example
🚧 Files skipped from review as they are similar to previous changes (2)
- Dockerfile
- apps/indexer/config.yaml
⏰ Context from checks skipped due to timeout of 300000ms (1)
- GitHub Check: e2e-tests / E2E Tests
🤖 Linear
Closes PAR-946
Description
Checklist before requesting a review
Summary by CodeRabbit