Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish translations (419 = Latin America) #6940

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MiguelElGallo
Copy link

Hi!
I have followed the instructions and added translations for Spanish, Country Latin America 419 according to this and other online sources.
In the provided links there was no references to 419, but I created it via the suggested command:
msginit -i po/com.mitchellh.ghostty.pot -l es_419.UTF-8 -o "po/es_419.UTF-8.po"
Glad to be able to contribute to this excellent product!
Cheers!

@MiguelElGallo
Copy link
Author

MiguelElGallo commented Mar 28, 2025

@00-kat could you take a look, please :)

@MiguelElGallo
Copy link
Author

Also found in https://unstats.un.org/unsd/methodology/m49/
That 419 is Latin America and Caribean
image

@MiguelElGallo
Copy link
Author

Adde new commit with _BO (Bolivia) in case 419 does not work in some supported platforms.

Copy link
Contributor

@00-kat 00-kat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@00-kat could you take a look, please :)

I know nothing about Spanish but I don't spot any punctuation issues or anything.

And as I previously mentioned, I know approximately nothing about locale codes so I can't confirm if 419 is definitely Latin America.

Also found in https://unstats.un.org/unsd/methodology/m49/

The source is definitely reputable so I doubt it's wrong though. I just don't know if gettext would like it.

@MiguelElGallo
Copy link
Author

I can also commit to maintenance of the translation.

@Uzaaft
Copy link
Contributor

Uzaaft commented Mar 29, 2025

just waiting on another speaker of Spanish reviewing for QA and we should be ready to go.

I can also commit to maintenance of the translation.

Awesome! 🚀

Copy link

@piedrahitac piedrahitac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native spanish speaker here... This looks good!

@pluiedev pluiedev added the translations Translations of the Ghostty app label Mar 30, 2025
@pluiedev
Copy link
Member

I'm not sure if es_419 would work... it has to match whatever locale code is set in the user's LANGUAGE environment variable, and to my knowledge they all look like es_MX, es_BO, es_AR, etc. We might need either some special logic to map those locales to one translation, or to duplicate them entirely, which is potentially beneficial for allowing more regionalized expressions but I don't know how much more maintenance burden that would bring.

@MiguelElGallo
Copy link
Author

Yeah, not sure either if 419 will work, but it is something. (See point 4)
This URL is also interesting: https://translate.fedoraproject.org/languages/es_419/. This means there are some Linux that support 419.
I think would be good to have this merged.

@jacostag
Copy link

jacostag commented Apr 1, 2025

Spanish speaker here... This looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Translations of the Ghostty app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants