-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spanish translations (419 = Latin America) #6940
base: main
Are you sure you want to change the base?
Conversation
@00-kat could you take a look, please :) |
Also found in https://unstats.un.org/unsd/methodology/m49/ |
Adde new commit with _BO (Bolivia) in case 419 does not work in some supported platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@00-kat could you take a look, please :)
I know nothing about Spanish but I don't spot any punctuation issues or anything.
And as I previously mentioned, I know approximately nothing about locale codes so I can't confirm if 419 is definitely Latin America.
Also found in https://unstats.un.org/unsd/methodology/m49/
The source is definitely reputable so I doubt it's wrong though. I just don't know if gettext would like it.
I can also commit to maintenance of the translation. |
just waiting on another speaker of Spanish reviewing for QA and we should be ready to go.
Awesome! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native spanish speaker here... This looks good!
I'm not sure if es_419 would work... it has to match whatever locale code is set in the user's LANGUAGE environment variable, and to my knowledge they all look like es_MX, es_BO, es_AR, etc. We might need either some special logic to map those locales to one translation, or to duplicate them entirely, which is potentially beneficial for allowing more regionalized expressions but I don't know how much more maintenance burden that would bring. |
Yeah, not sure either if 419 will work, but it is something. (See point 4) |
Spanish speaker here... This looks good! |
Hi!
I have followed the instructions and added translations for Spanish, Country Latin America 419 according to this and other online sources.
In the provided links there was no references to 419, but I created it via the suggested command:
msginit -i po/com.mitchellh.ghostty.pot -l es_419.UTF-8 -o "po/es_419.UTF-8.po"
Glad to be able to contribute to this excellent product!
Cheers!