-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snap: Build with gtk4-layer-shell and dependencies #6920
base: main
Are you sure you want to change the base?
Conversation
snap/snapcraft.yaml
Outdated
ninja: | ||
plugin: nil | ||
source: https://github.com/ninja-build/ninja.git | ||
source-tag: 'v1.12.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this because the version in noble
is too old?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because the way snapcraft needs "meson-deps" internally
snap/snapcraft.yaml
Outdated
after: [ ninja ] | ||
plugin: nil | ||
source: https://github.com/mesonbuild/meson.git | ||
source-tag: '1.6.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question, noting that meson
1.5 is in noble-updates
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's possible that meson in noble-updates might work today, but it could stop working pretty quickly as gtk updates, so this makes it trivial to build app the components that gtk4 needs just by bumping tags as needed.
Actual changes look sound technically, my only question is whether or not it's worth waiting for the (EDIT: Ah, perhaps you can't use that with a |
Correct, we can't leverage the content snap for classic |
f1a7f32
to
19c1cd4
Compare
19c1cd4
to
8ec3a61
Compare
8ec3a61
to
49f461f
Compare
This vendors gtk4-layer-shell and dependencies into the snap to enable support in ghostty