Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: Build with gtk4-layer-shell and dependencies #6920

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kenvandine
Copy link
Contributor

This vendors gtk4-layer-shell and dependencies into the snap to enable support in ghostty

@kenvandine kenvandine requested a review from a team as a code owner March 26, 2025 16:33
ninja:
plugin: nil
source: https://github.com/ninja-build/ninja.git
source-tag: 'v1.12.1'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because the version in noble is too old?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because the way snapcraft needs "meson-deps" internally

after: [ ninja ]
plugin: nil
source: https://github.com/mesonbuild/meson.git
source-tag: '1.6.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question, noting that meson 1.5 is in noble-updates?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's possible that meson in noble-updates might work today, but it could stop working pretty quickly as gtk updates, so this makes it trivial to build app the components that gtk4 needs just by bumping tags as needed.

@jnsgruk
Copy link

jnsgruk commented Mar 26, 2025

Actual changes look sound technically, my only question is whether or not it's worth waiting for the latest/candidate revision of the gnome-46-2404 snap to be released, which contains much of the hand-build stuff you need?

(EDIT: Ah, perhaps you can't use that with a classic snap...)

@kenvandine
Copy link
Contributor Author

Actual changes look sound technically, my only question is whether or not it's worth waiting for the latest/candidate revision of the gnome-46-2404 snap to be released, which contains much of the hand-build stuff you need?

(EDIT: Ah, perhaps you can't use that with a classic snap...)

Correct, we can't leverage the content snap for classic

@kenvandine kenvandine force-pushed the snap-gtk4-layer-shell branch from 8ec3a61 to 49f461f Compare March 29, 2025 01:23
@kenvandine kenvandine marked this pull request as draft March 31, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants