snap: build from source tarball #6831
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
reviewed
Mar 20, 2025
There was a problem hiding this comment.
One comment, definitely want @kenvandine's thoughts on this. I like it!
kenvandine
reviewed
Mar 20, 2025
snap/snapcraft.yaml
Outdated
| @@ -80,7 +79,7 @@ parts: | |||
| - patchelf | |||
| - gettext | |||
| override-build: | | |||
| craftctl set version=$(git describe --abbrev=8) | |||
| craftctl set version=$(cat .version) | |||
There was a problem hiding this comment.
How is . version generated? The nice thing about git describe can be useful to create a meaningful version string that has a relationship to a commit.
There was a problem hiding this comment.
The version for dev builds will look like this: 1.1.3-HEAD+88ff566e, matching ghostty +version shows and the "about" panel. It's all sourced from the same string. Release builds would show up as-is like 1.2.0.
jcollie
force-pushed
the
snap-source-tarball-build
branch
from
87f882c to
5e06e4b
Compare
pluiedev
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates the need for
blueprint-compiler, which isn't quite new enough on the snap builder.