Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zh_TW Traditional Chinese locale #6773

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PeterDaveHello
Copy link

🎉

@pluiedev pluiedev added the translations Translations of the Ghostty app label Mar 17, 2025
@mitchellh
Copy link
Contributor

Do you accept being on the zh_TW localization team @PeterDaveHello for future review?

@PeterDaveHello
Copy link
Author

Do you accept being on the zh_TW localization team @PeterDaveHello for future review?

Sure!

Copy link
Member

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really have further comments as a dumb mainlander — ideally we should have one more person willing to step up as a maintainer before we'd accept these

@PeterDaveHello
Copy link
Author

@pluiedev I can help maintain it ;)

@pluiedev
Copy link
Member

pluiedev commented Mar 21, 2025

Yeah, what I mean is that we should ideally have one other person to serve as a co-translator or a proofreader to ensure the quality of translations.

@PeterDaveHello
Copy link
Author

Ideally, every role should have at least one backup. However, I'm unsure if this should be a strict requirement in practice. As you know, this is an open-source project supported by volunteers. Therefore, perhaps we can consider it as an additional, non-mandatory task.

@PeterDaveHello
Copy link
Author

Another thought that may be helpful: as an open source projects maintainer who doesn't understand more than two languages, those frontier LLMs are my friends to help proofread. They may not be able to translate perfectly, but they're very helpful in checking whether the translations are understandable, reasonable, and improved.

@mitchellh
Copy link
Contributor

Another thought that may be helpful: as an open source projects maintainer who doesn't understand more than two languages, those frontier LLMs are my friends to help proofread. They may not be able to translate perfectly, but they're very helpful in checking whether the translations are understandable, reasonable, and improved.

Yeah absolutely. I'd love to see a GH bot or something (maybe it exists) that does this specifically for PO files since they're an all known format. I do it manually right now (I've run a handful of our PRs through an LLM) and its helpful but having something more automated and in the loop would be a great help.

@PeterDaveHello
Copy link
Author

Yeah absolutely. I'd love to see a GH bot or something (maybe it exists) that does this specifically for PO files since they're an all known format. I do it manually right now (I've run a handful of our PRs through an LLM) and its helpful but having something more automated and in the loop would be a great help.

Maybe take a look at https://www.qodo.ai/ and https://coderabbit.ai/, though they aren't designed for the po files, they absolutely can and will help review translation, additionally, also for the other changes in the project.

@PeterDaveHello
Copy link
Author

@mitchellh @pluiedev, with respect, is there any chance we can move on? As there seemed to be merge conflict now, I'm not sure if it should be resolved ;)

Copy link

@pan93412 pan93412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome translation! There are just a few points to discuss :)

Regarding the merge conflict issues, I suggest discarding the file i18n.zig, rebasing to the main branch, and then reapplying this patch. After that, this PR will be mergeable, and the maintainer won't need to rebase it manually.

git am 0001-l10n-add-zh-TW-entry.patch

0001-l10n-add-zh-TW-entry.patch


#: src/apprt/gtk/CloseDialog.zig:90
msgid "Close Split?"
msgstr "是否要關閉分割區?"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose 分割窗格, where 窗格 is pane:

A pane is a (usually) independently scrollable subsection of a window.

#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:33
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:45
msgid "Change Title…"
msgstr "變更標題……"
Copy link

@pan93412 pan93412 Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Change Title…" might open a new popup that allows users to change the title. In this case, I suggest using three dots for a shorter menu label.

#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:38
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:50
msgid "Split Up"
msgstr "向上分割"
Copy link

@pan93412 pan93412 Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the behavior of this button, I propose 切出 <direction> 窗格 so users understand its function. For example, 切出左窗格. "向上分割" often does not convey its meaning clearly.

CleanShot 2025-03-28 at 22 32 15@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Translations of the Ghostty app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants