-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zh_TW Traditional Chinese locale #6773
base: main
Are you sure you want to change the base?
Conversation
Do you accept being on the zh_TW localization team @PeterDaveHello for future review? |
Sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't really have further comments as a dumb mainlander — ideally we should have one more person willing to step up as a maintainer before we'd accept these
@pluiedev I can help maintain it ;) |
Yeah, what I mean is that we should ideally have one other person to serve as a co-translator or a proofreader to ensure the quality of translations. |
Ideally, every role should have at least one backup. However, I'm unsure if this should be a strict requirement in practice. As you know, this is an open-source project supported by volunteers. Therefore, perhaps we can consider it as an additional, non-mandatory task. |
Another thought that may be helpful: as an open source projects maintainer who doesn't understand more than two languages, those frontier LLMs are my friends to help proofread. They may not be able to translate perfectly, but they're very helpful in checking whether the translations are understandable, reasonable, and improved. |
Yeah absolutely. I'd love to see a GH bot or something (maybe it exists) that does this specifically for PO files since they're an all known format. I do it manually right now (I've run a handful of our PRs through an LLM) and its helpful but having something more automated and in the loop would be a great help. |
Maybe take a look at https://www.qodo.ai/ and https://coderabbit.ai/, though they aren't designed for the po files, they absolutely can and will help review translation, additionally, also for the other changes in the project. |
@mitchellh @pluiedev, with respect, is there any chance we can move on? As there seemed to be merge conflict now, I'm not sure if it should be resolved ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome translation! There are just a few points to discuss :)
Regarding the merge conflict issues, I suggest discarding the file i18n.zig
, rebasing to the main branch, and then reapplying this patch. After that, this PR will be mergeable, and the maintainer won't need to rebase it manually.
git am 0001-l10n-add-zh-TW-entry.patch
|
||
#: src/apprt/gtk/CloseDialog.zig:90 | ||
msgid "Close Split?" | ||
msgstr "是否要關閉分割區?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose 分割窗格
, where 窗格
is pane
:
A pane is a (usually) independently scrollable subsection of a window.
#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:33 | ||
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:45 | ||
msgid "Change Title…" | ||
msgstr "變更標題……" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Change Title…" might open a new popup that allows users to change the title. In this case, I suggest using three dots for a shorter menu label.
#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:38 | ||
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:50 | ||
msgid "Split Up" | ||
msgstr "向上分割" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉