-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTK: title
config should be respected and set immediately on new windows, tabs
#5934
Comments
pluiedev
added a commit
to pluiedev/ghostty
that referenced
this issue
Feb 24, 2025
Fixes ghostty-org#5934 (only on the GTK side), ghostty-org#5960
pluiedev
added a commit
to pluiedev/ghostty
that referenced
this issue
Feb 24, 2025
Fixes ghostty-org#5934 (only on the GTK side), ghostty-org#5960
pluiedev
added a commit
to pluiedev/ghostty
that referenced
this issue
Feb 24, 2025
Fixes ghostty-org#5934 (only on the GTK side), ghostty-org#5960
pluiedev
added a commit
to pluiedev/ghostty
that referenced
this issue
Feb 24, 2025
Fixes ghostty-org#5934 (only on the GTK side), ghostty-org#5960
pluiedev
added a commit
to pluiedev/ghostty
that referenced
this issue
Feb 25, 2025
Fixes ghostty-org#5934 (only on the GTK side), ghostty-org#5960
pluiedev
added a commit
to pluiedev/ghostty
that referenced
this issue
Feb 25, 2025
Fixes ghostty-org#5934 (only on the GTK side), ghostty-org#5960
mitchellh
added a commit
that referenced
this issue
Mar 2, 2025
Fixes #5934 for macOS If a `title` config is set, this change sets the title immediately on windowDidLoad to ensure that the window appears with the correct title right away. If there is any reason to set another title, the `set_title` apprt action will come on another event loop tick (due to our usage of notifications) but that's okay since that's already how it works. This is just to say that setting this here won't break any shell integration or anything.
macOS resolved, Linux still an issue, renamed and relabeled. |
title
config should be respected and set immediately on new windows, tabstitle
config should be respected and set immediately on new windows, tabs
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discussed in #5836
Originally posted by vaygr February 17, 2025
Steps to reproduce:
Even though the title is reported correctly once ghostty is launched:
But the rule never gets triggered, that is unless I remove
title
argument foryabai -m rule
or set it to^.*$
.I tested it with kitty to see if it could be yabai's issue, but no, it worked as expected:
My assumption is ghostty could be setting the title a bit too late?
Notes
Right now, the core Surface sends a
set_title
apprt action AFTER the surface is initialized, which -- at least for macOS -- happens to be after the Window (tabs are also windows in macOS) is created.If the user sets an explicit
title
config, we should set that as part of the window creation process rather than wait for this message.The text was updated successfully, but these errors were encountered: