Skip to content

Added option for forwarding upload request #2644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

develeon
Copy link
Contributor

Proposal to extend the QuickAdapter with a boolean forwardUploadRequests which can be set true
in order to forward upload request/multipart form-data to the upload handler.

In this way clients do not have to change endpoints for upload requests.

@ghostdogpr what do you think?

@develeon develeon force-pushed the series/2.x_enable_forwardUploads branch from ecaafdd to 20890d5 Compare May 14, 2025 10:37
@ghostdogpr
Copy link
Owner

How about removing the parameter and apply that behavior if apiPath == uploadPath (building a single route)?

@develeon
Copy link
Contributor Author

develeon commented May 19, 2025

How about removing the parameter and apply that behavior if apiPath == uploadPath (building a single route)?

That sounds like a better approach.
I want to add, that Graphql Multipart seem to have some issues with cross site forgery,
so we are going to moving away from it and think we will rather do the signed URL approach.

Found this for best practises
Maybe could be worth adding a word of caution..

@paulpdaniels
Copy link
Collaborator

Found this for best practises Maybe could be worth adding a word of caution..

Don't read too much into that Apollo really only considered it a bad practice until they could put it behind an enterprise flag: https://www.apollographql.com/docs/graphos/routing/configuration/yaml#preview_file_uploads

@develeon develeon force-pushed the series/2.x_enable_forwardUploads branch 2 times, most recently from 1a66d44 to a5ce142 Compare June 7, 2025 16:25
@develeon develeon force-pushed the series/2.x_enable_forwardUploads branch from a5ce142 to 3616121 Compare June 8, 2025 20:52
@ghostdogpr ghostdogpr merged commit 5b30bc7 into ghostdogpr:series/2.x Jun 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants