whisper : fix "bench-all outputs an invalid result on larger models" #3002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run
scripts/bench-all.sh
on AWS c8g.xlarge, it outputsan invalid number (
"ms"
) in the result table.Look at the 'Encode' column in the benchmark result below:
Running bench-all.sh (commit 6e7629b)
The reason is that the benchmark script assumes that the 11th field is
a timestamp, but this assumption can break when the target model
takes a longer time to process.
This is a trivial fix for the issue, adding an explicit whitespace before
the timestamp field.
Running bench-all.sh (commit a7cf427)