missing #include for strcasecmp #4596
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Posix specifications say you need strings.h to use strcasecmp - it happens to work on most Linux systems without it, but that's basically just a compiler include bug (i think?) - Cygwin gcc actually requires string.h, compiling on Cygwin is how I noticed strings.h was missing
divinity76
changed the title
|
The upstream project is actively maintained, it would probably be worth opening a PR there: https://github.com/yhirose/cpp-httplib Since no supported platforms seem to require this, I don't think it's a priority to merge the change here first. |
|
@cebtenzzre added a upstream PR yhirose/cpp-httplib#1744 and closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posix specifications say you need strings.h to use strcasecmp