ggml : do not output unprintable characters on GGUF load failure #14381
Conversation
github-actions
bot
added
the
ggml
|
It would maybe be nice to also add a test case to |
Test for what though? |
Could capture stderr I guess? |
|
I don't know, would depend on what kind of issues you were able to provoke without the change. You could maybe assert that with unprintable characters in the gguf magic the string |
|
I tried, but since GGML_LOG writes to |
|
That's fine, as long as it's not possible to provoke major issues such as a crash it's not that important anyways. |
No, at worst it will mess up your terminal on the right character sequence. |
* mamba2-sync: (22 commits) recurrent : call balloc split_reset() in init_batch() (ggml-org#14414) ggml : add ggml_set_rows (ggml-org#14274) convert : fix broken sentencepiece vocab (ggml-org#14416) mamba : fix mismatched new and delete size for llm_build_mamba model : gemma3n text-only (ggml-org#14400) cmake: regen vulkan shaders when shaders-gen sources change (ggml-org#14398) llama : return mistral-v7-tekken as default template only (ggml-org#14390) metal : add special-case mat-vec mul for ne00 == 4 (ggml-org#14385) metal : batch rows copy in a single threadgroup (ggml-org#14384) docs: update s390x documentation + add faq (ggml-org#14389) musa: enable fp16 mma (all) and cublas on qy2 (ggml-org#13842) ggml-cpu: enable IBM NNPA Vector Intrinsics (ggml-org#14317) ggml : do not output unprintable characters on GGUF load failure (ggml-org#14381) sycl: GGML_SYCL_DISABLE_OPT on by default for all Intel Devices (ggml-org#13973) opencl: ref count `ggml_backend_opencl_context` and refactor profiling (ggml-org#14254) batch : fix check for empty sequences in memory (ggml-org#14364) cmake : use LLAMA_BUILD_NUMBER when defining LLAMA_INSTALL_VERSION (ggml-org#14362) server : move no API key doc to /health (ggml-org#14352) main : honor --verbose-prompt on interactive prompts (ggml-org#14350) jinja : Add Mistral-Small-3.2-24B-Instruct-2506.jinja (ggml-org#14349) ...
On failure to load a GGUF the first four characters of the file will be output to the console, leading to all kinds of trouble depending on the characters.
This is especially important to resolve before starting to support GGUF for other kinds of data files, see #9400 (review)