clip : fix confused naming ffn_up and ffn_down #13290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
clip.cpp
code reverse the ffn_up and ffn_down naming by mistake, which make it extremely messy when migrating the conversion script toconvert_hf_to_gguf.py
To save myself from some headaches, so I decided to fix it once and for all 😤😤
The new rule is:
This PR also contain name changing to make it more align with
llama.cpp
style:n_intermediate
-->n_embd
hidden_size
-->n_ff
Small note: GGUF converted from the old qwen surgery script has
n_ff = 0
, hopefully this will not be messy in the futureTested by converting fresh new GGUF and run it with
llama-mtmd-cli
locally:Tested with existing GGUF on the internet: