Get CPU model in ggml_backend_cpu_device_context on FreeBSD #12902
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
yurivict
force-pushed
the
FreeBSD-cpu-model
branch
from
add4dae to
9b6b704
Compare
slaren
reviewed
Apr 12, 2025
Comment on lines
+29
to
+31
| #include <errno.h> | ||
| #include <string.h> | ||
| #include <iostream> |
There was a problem hiding this comment.
Unless necessary for something else in this file, remove these includes.
Suggested change
| #include <errno.h> | |
| #include <string.h> | |
| #include <iostream> |
Comment on lines
+300
to
+303
| if (rc == 0) | ||
| description = buf; | ||
| else | ||
| std::cerr << "error: sysctlbyname(hw.model) failed: " << strerror(errno) << std::endl; |
There was a problem hiding this comment.
Suggested change
| if (rc == 0) | |
| description = buf; | |
| else | |
| std::cerr << "error: sysctlbyname(hw.model) failed: " << strerror(errno) << std::endl; | |
| if (rc == 0) { | |
| description = buf; | |
| } |
It's unlikely, but what if this system call would fail for some odd reason, like resource exhaustion. |
|
The most important reason is for consistency with the rest of the code. This is not a critical function and it doesn't matter if it fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.