-
Notifications
You must be signed in to change notification settings - Fork 29
SPM: adding package to another package #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Replacing |
Thanks for this. it now imports whisper.spm.
I have a follow-up.
I’ve followed the swift example, and made a few changes to the WhisperState, mainly to do asynchronous AVAudioInputNode tapping and transcribing.
I get the following:
Cannot find type 'WhisperContext' in scope
I’ve imported Whisper and checked what types it has, but no WhisperContext.
Should I just clone the example and extend it, then make a pull request? I think having streaming input capture and transcribing would be useful.
Thanks
… On 27 Jan 2023, at 2:56 am, Finn Voorhees ***@***.***> wrote:
Replacing dependencies with [.product(name: "whisper", package: "whisper.spm")] should fix it. You can then import whisper to use.
—
Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJHQFI7DMJ4FKXXDUJB52TWUKUCVANCNFSM6AAAAAAUHJZKJE>.
You are receiving this because you authored the thread.
|
This package is just a wrapper around the |
Ok thanks for the clarification. I was looking to include it in another package to extend the whisper.spm package but this won’t be possible as swift packages aren’t compatible with mix languages.
I’ll find a different way of extending the WhisperState to have the AVAudioInputNode tapping, even if it means importing a project into a project. Will just have to wait for multi language support in SPM.
… On 27 Jan 2023, at 9:15 pm, Finn Voorhees ***@***.***> wrote:
This package is just a wrapper around the whisper.cpp files/headers. It seems like you are following the whisper.cpp whisper.swiftui.demo app, which defines WhisperContext here <https://github.com/ggerganov/whisper.cpp/blob/master/examples/whisper.swiftui/whisper.cpp.swift/LibWhisper.swift>. You should be able to get it working by just copying over that file.
—
Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJHQFJF2BZBHZIFT63QRRDWUOU47ANCNFSM6AAAAAAUHJZKJE>.
You are receiving this because you authored the thread.
|
Sorry for the long delay in replying, I have been overloaded at work, and just getting back.
I think I might fork the project, add the streaming audio capture feature and do a pull request.
… On 29 Jan 2023, at 9:52 pm, Chidi Williams ***@***.***> wrote:
@triple7 <https://github.com/triple7>, @finnvoor <https://github.com/Finnvoor>, did either of you run into a similar issue importing this project to Xcode? #4 <#4>
—
Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJHQFPAAQ4G7FCCXIOTTZLWUZKXHANCNFSM6AAAAAAUHJZKJE>.
You are receiving this because you were mentioned.
|
iandundas
pushed a commit
to jordibruin/Whisper
that referenced
this issue
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey, first off great repo man. Was about to write a swift wrapper then I saw your spam :)
Just having an issue with below message:
product 'whisper.spm' required by package 'swiftwhisper' target 'SwiftWhisperTests' not found in package 'whisper.spm'.
The line where it's hanging is:
.testTarget(
name: "SwiftWhisperTests",
dependencies: ["SwiftWhisper", .product(name: "whisper.spm", package: "whisper.spm")]),
]
I tried whisper.cpp as package or product but that doesn't work. Is there another name to be included? as the normal target dependency works.
The text was updated successfully, but these errors were encountered: