Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wgpu] Blas compaction #7285

Open
wants to merge 59 commits into
base: trunk
Choose a base branch
from
Open

[wgpu] Blas compaction #7285

wants to merge 59 commits into from

Conversation

Vecvec
Copy link
Collaborator

@Vecvec Vecvec commented Mar 6, 2025 •
edited
Loading

Connections
Builds on #7101

Description
Adds BLAS compaction into wgpu (see wgpu-hal changes #7101)

Testing
Adds tests for the added API

Squash or Rebase?
Squash

Checklist

  • Run cargo fmt.
  • [n/a] Run taplo format.
  • Run cargo clippy. If applicable, add:
    • [n/a] --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

Vecvec added 30 commits February 11, 2025 08:52
@Vecvec
Initial.
f95d902
@Vecvec
Changelog.
9f04c3a
@Vecvec
Compact readback.
cb44cfc
@Vecvec
Make comment better.
113f35c
@Vecvec
Implement BLAS compaction
d9e0e68
@Vecvec
Implement readback in BLAS build and add to ray_cube_compute.
d4ded66
@Vecvec
Format.
8cf7ef4
@Vecvec
Make docs clearer
c7c529e
@Vecvec
Reset BLAS state to idle when building, disallow compacted BLASes bei…
d17ab7d 
…ng rebuilt.
@Vecvec
Reset BLAS state to idle when building, disallow compacted BLASes bei…
10979f8 
…ng rebuilt.
@Vecvec
Fix CI.
315206c
@Vecvec
Format.
60e4f0f
@Vecvec
Fix msrv.
5117003
@Vecvec
Note possible optimisation.
3b553aa
@Vecvec
Change check for compaction to flag.
f2de65b
@Vecvec
Add tests.
f2a1e48
@Vecvec
Fix unused import warning.
5f8f5b1
@Vecvec
Make comment better.
928a89d
@Vecvec
Move resetting to idle to validate_blas_actions
a666ddf
@Vecvec
Add [Blas::ready_for_compaction].
75c82ba
@Vecvec
Rename to compact_result.
acb2026
@Vecvec
Format.
205fa26
@Vecvec
Make compact_blas to queue impl due to it needing to happen in order.
c0c24d7
@Vecvec
Clippy & format.
181a9fb
@Vecvec
Clippy.
04053b0
@Vecvec
Format (again).
9050d94
@Vecvec
Closing on comment.
ab727dc
@Vecvec
Update comment.
29a45b7
@Vecvec
Fix building not checking a blas wasn't compacted.
4752fc3
@Vecvec
State BLAS functions are impl'd
aae428b
@Vecvec Vecvec requested a review from a team as a code owner March 6, 2025 20:28
@cwfitzgerald cwfitzgerald self-assigned this Mar 12, 2025
@Vecvec Vecvec mentioned this pull request Mar 15, 2025
Open
27 tasks
cwfitzgerald
cwfitzgerald requested changes Apr 9, 2025
View reviewed changes
@Vecvec
Copy link
Collaborator Author

Vecvec commented Apr 11, 2025

I think all the import issues have now been resolved.

@Vecvec Vecvec requested a review from cwfitzgerald April 11, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald Awaiting requested review from cwfitzgerald

Requested changes must be addressed to merge this pull request.

Assignees

@cwfitzgerald cwfitzgerald

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vecvec @cwfitzgerald