[wgpu-core] when mapping buffers for reading, mark buffers as initialized only when they have MAP_WRITE usage
#6178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
force-pushed
the
gles-flush-explicit
branch
from
7268700 to
afcc390
Compare
ErichDonGubler
requested changes
Aug 28, 2024
teoxoy
force-pushed
the
gles-flush-explicit
branch
3 times, most recently
from
520730e to
2a8cbd9
Compare
ErichDonGubler
approved these changes
Aug 29, 2024
teoxoy
changed the title
MAP_FLUSH_EXPLICIT_BIT for MAP_READ buffers as wellMAP_WRITE usage
teoxoy
force-pushed
the
gles-flush-explicit
branch
from
2a8cbd9 to
0b76e1e
Compare
|
@teoxoy: If @Wumpf and @cwfitzgerald don't have anything to say by ~Wednesday, I think it'd be fair to just merge, if not earlier. |
|
I'll run the test case in #6137 against this on my machine. |
|
This patch does indeed silence the GLES validation error provoked on trunk by the test in #6137. |
…ized only when they have `MAP_WRITE` usage
ErichDonGubler
force-pushed
the
gles-flush-explicit
branch
from
0b76e1e to
5500c84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6137.
I couldn't test this locally as my buffer mappings seem to be coherent but the new
wgpu_test::dispatch_workgroups_indirect::reset_bind_groupstestcase in #5714 runs into this.