Skip to content

Rg11b10Float -> Rg11b10UFloat and deduplicate entries in TEXTURE_FORMAT_LIST #6108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

sagudev
Copy link
Collaborator

@sagudev sagudev commented Aug 12, 2024

Connections
Per matrix chat: https://matrix.to/#/!FZyQrssSlHEZqrYcOb:matrix.org/$D9vAz13xeqkwM2npD3Zb6dANh87s7pwfWagevtAQwxw?via=matrix.org&via=mozilla.org&via=nitro.chat

Description
Rg11b10Float is renamed to Rg11b10UFloat, to match the spec.

Reviewable per commits.

Testing
New test for uniqueness in TEXTURE_FORMAT_LIST.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@sagudev sagudev requested a review from a team August 12, 2024 15:54
@sagudev sagudev requested a review from a team as a code owner August 12, 2024 15:54
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ErichDonGubler ErichDonGubler enabled auto-merge (squash) August 13, 2024 08:17
@ErichDonGubler ErichDonGubler merged commit c6a3d92 into gfx-rs:trunk Aug 13, 2024
25 checks passed
ErichDonGubler added a commit to erichdongubler-mozilla/wgpu that referenced this pull request Oct 25, 2024
ErichDonGubler added a commit to erichdongubler-mozilla/wgpu that referenced this pull request Oct 29, 2024
ErichDonGubler added a commit to erichdongubler-mozilla/wgpu that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants