Skip to content

Print requested and supported usages on UnsupportedUsage error #6007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

VladasZ
Copy link
Contributor

@VladasZ VladasZ commented Jul 21, 2024

Description
ConfigureSurfaceError::UnsupportedUsage error log message is not very informative.

Testing
This is how it looks with this change:
image

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@VladasZ VladasZ marked this pull request as ready for review July 22, 2024 00:05
@VladasZ VladasZ requested a review from a team as a code owner July 22, 2024 00:05
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@cwfitzgerald cwfitzgerald merged commit 5a0e218 into gfx-rs:trunk Jul 22, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants