This repository was archived by the owner on Jan 29, 2025. It is now read-only.
[wgsl-in] Fix expected min arg count of textureLoad
#2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Looks good to me.
I haven't tried it, but it seems like it would be nicer to compute min_args's final value in one place, as soon as we knew the image type, rather than having it be a side effect of random closures. But that problem was there already, so we don't need to address it here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2583
Also double-checked the min arg count of the other functions.
It was most likely incorrect due to the spec previously only having overloads with min 3 args but with gpuweb/gpuweb#4326 (which we have parts of implemented already) new overloads with min 2 args have been added.