Skip to content
This repository was archived by the owner on Jan 29, 2025. It is now read-only.

Bump minimum supported Rust version (MSRV) to 1.65. #2420

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

jimblandy
Copy link
Member

No description provided.

@jimblandy jimblandy requested a review from teoxoy August 1, 2023 22:39
@jimblandy jimblandy changed the title Bump MSRV to 1.65. Bump minimum supported Rust version (MSRV) to 1.65. Aug 1, 2023
@jimblandy
Copy link
Member Author

jimblandy commented Aug 1, 2023

wgpu's minimum supported Rust version is 1.65.

Firefox's is 1.66.

[updated] cargo test --all-features --workspace also trips over criterion's indirect on clap_builder 4.3.19, whose MSRV is 1.64.

Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CLI depends on clap_builder 4.3.19, whose MSRV is 1.64.

Is this the case? clap_builder is only used by clap which in turn is only used by criterion; which is a dev dependency. We also have MSRV checks in CI to make sure we don't depend on crates with a higher MSRV than the one we advertise.

@jimblandy
Copy link
Member Author

jimblandy commented Aug 2, 2023

Is this the case? clap_builder is only used by clap which in turn is only used by criterion; which is a dev dependency. We also have MSRV checks in CI to make sure we don't depend on crates with a higher MSRV than the one we advertise.

You're right. I edited my comment.

@jimblandy jimblandy merged commit 543cae1 into gfx-rs:master Aug 2, 2023
@jimblandy jimblandy deleted the msrv-1.65 branch September 20, 2023 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants