This repository was archived by the owner on Jan 29, 2025. It is now read-only.
[glsl-out] Add built-in functions to keywords #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! While looking it over, I ended up checking the spec repo and documented where the keywords come from (also adding a few missing ones). I also removed the ones starting with Line 493 in 5f8e4f6 |
|
Let me know if it looks good, and we can land it. |
|
Related: We should be renaming identifiers containing two consecutive underscores (see #2412). |
|
@teoxoy Looks good to me, nice work with the references!
Aha, didn't know that, thanks for the pointer! |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add built-in functions to keywords. Fixes #2276 and part of gfx-rs/wgpu#4555.
As the comment shows this is taken from https://dawn.googlesource.com/dawn/+/refs/heads/main/src/tint/lang/wgsl/ast/transform/renamer.cc#39 - is that ok? Any ideas for a reference of this?
List of removed keywords:
Rectuimage2DMSArraystructList of added keywords:
absacosacoshallanyasinasinhatanatanhatomicAddatomicAndatomicCompSwapatomicCounteratomicCounterDecrementatomicCounterIncrementatomicExchangeatomicMaxatomicMinatomicOratomicXorbarrierbitCountbitfieldExtractbitfieldInsertbitfieldReverseceilclampcoscoshcrossdFdxdFdydegreesdeterminantdistancedotequalexpexp2faceforwardfindLSBfindMSBfloatBitsToIntfloatBitsToUintfloorfractfrexpfwidthgl_BaseInstancegl_BaseVertexgl_ClipDistancegl_DepthRangeParametersgl_DrawIDgl_FragCoordgl_FragDepthgl_FrontFacinggl_GlobalInvocationIDgl_InstanceIDgl_LocalInvocationIDgl_LocalInvocationIndexgl_NumSamplesgl_NumWorkGroupsgl_PerVertexgl_PointCoordgl_PointSizegl_Positiongl_PrimitiveIDgl_SampleIDgl_SampleMaskgl_SampleMaskIngl_SamplePositiongl_VertexIDgl_WorkGroupIDgl_WorkGroupSizegreaterThangreaterThanEqualgroupMemoryBarrierimageLoadimageSizeimageStoreimulExtendedintBitsToFloatinverseinversesqrtisampler2DRectisinfisnanldexplengthlessThanlessThanEqualloglog2matrixCompMultmaxmemoryBarriermemoryBarrierAtomicCountermemoryBarrierBuffermemoryBarrierImagememoryBarrierSharedminmixmodmodfnormalizenotnotEqualouterProductpackHalf2x16packSnorm2x16packSnorm4x8packUnorm2x16packUnorm4x8powradiansreflectrefractroundroundEvensignsinsinhsmoothstepsqrtstepstructtantanhtexelFetchtexelFetchOffsettexturetextureGathertextureGatherOffsettextureGradtextureGradOffsettextureLodtextureLodOffsettextureOffsettextureProjtextureProjGradtextureProjGradOffsettextureProjLodtextureProjLodOffsettextureProjOffsettextureSizetransposetruncuaddCarryuimage2DMSArrayuintBitsToFloatumulExtendedunpackHalf2x16unpackSnorm2x16unpackSnorm4x8unpackUnorm2x16unpackUnorm4x8usubBorrow