This repository was archived by the owner on Jan 29, 2025. It is now read-only.
glsl-in: relational vector functions improvements #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `equal` and `notEqual` builtins also operate on boolean vectors but the overloads accepting them were not added. This commit fixes that.
All relational vector builtins that operate on floats can also operate on doubles but these overloads were not present. This commit fixes that.
JCapucho
force-pushed
the
glsl-bool-rel-builtins-fixes
branch
from
f2bca93 to
ff5b957
Compare
|
@teoxoy thanks for the heads up, since you've already approved I'll set it to auto merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some improvements related to the builtin relational vector functions, it's split into four independent commits that can be reviewed and tested individually.
Changes:
equalandnotEqualnot accepting boolean vectorsnotbuiltin (fixes [glsl-in] "not" is unsupported #2224)