This repository was archived by the owner on Jan 29, 2025. It is now read-only.
Supporting gl_PointCoord #2180
Merged
Supporting gl_PointCoord #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
suggested changes
Dec 20, 2022
src/back/hlsl/conv.rs
Outdated
| @@ -162,6 +162,7 @@ impl crate::BuiltIn { | |||
| Self::VertexIndex => "SV_VertexID", | |||
| // fragment | |||
| Self::FragDepth => "SV_Depth", | |||
| Self::PointCoord => "VPOS", | |||
There was a problem hiding this comment.
This is only available in dx9 / sm2 which we don't support. Let's error with "Unsupported builtin" instead (as we do for ViewIndex). And if we are here already, please also do the same for PointSize.
See also gpuweb/gpuweb#332 for more context.
There was a problem hiding this comment.
I don't think you can remove gl_PointSize that easily. In the quad-vert The hlsl backend emits PSIZE in the gl_PerVertex struct despite it not being used. I've only made it so that it errors with Unsupported builtin on gl_PointCoord.
There was a problem hiding this comment.
I see, thanks for trying though! I opened #2182 to do it later.
teoxoy
approved these changes
Dec 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
gl_PointCoordin the glsl frontend.