This repository was archived by the owner on Jan 29, 2025. It is now read-only.
build: move to the Rust 2021 edition #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
rust-2021-edition
branch
from
6274fb6 to
f9f66bc
Compare
Since the MSRV of `naga` [is currently 1.56][msrv], I don't think there's a strong reason to stay with the 2018 edition, and there _are_ a [few good reasons][edition-guide] to move to the 2021 edition. I did this migration mostly automatically, per [official Rust guidelines]: ```sh $ cargo fix --edition --all-targets $ sed -i Cargo.toml 's/2018/2021' $ cargo fix --edition-idioms --allow-dirty # doesn't change anything ``` The only manual edit needed to stymie a new warning introduced was the removal of the `TryFrom` import in several modules, since it's now in the 2021 prelude. [msrv]: https://github.com/gfx-rs/naga/blob/a7193d652e49180661a6ca047889e0685667acdb/.github/workflows/pipeline.yml#L14 [edition-guide]: https://doc.rust-lang.org/edition-guide/rust-2021/index.html [official Rust guidelines]: https://doc.rust-lang.org/cargo/commands/cargo-fix.html#edition-migration
ErichDonGubler
force-pushed
the
rust-2021-edition
branch
from
f9f66bc to
a0c3d16
Compare
jimblandy
suggested changes
Oct 24, 2022
How we were using `pat` in the Rust 2018 edition is actually the use case that Rust 2021's `pat` fragment specifier is intended to satisfy. So, let's just use that!
|
@jimblandy: Just fixed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the MSRV of
nagais currently 1.56, I don't think there's a strong reason to stay with the 2018 edition, and there are a few good reasons to move to the 2021 edition.I did this migration mostly automatically, per official Rust guidelines:
The only manual edit needed to stymie a new warning introduced was the removal of the
TryFromimport from several modules, since it's now in the 2021 prelude.