This repository was archived by the owner on Jan 29, 2025. It is now read-only.
wgsl-in: Splat on compound assignments #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
approved these changes
Sep 10, 2022
Compound assignments on wgsl follow the same semantics as their underlying operation, this includes the splatting behavior when mixing scalar and vector operands, which was done for binary operations but not for compound assignments.
JCapucho
force-pushed
the
wgsl-splat-compound-assignments
branch
from
62c2178 to
87b03b2
Compare
jimblandy
approved these changes
Sep 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compound assignments on wgsl follow the same semantics as their underlying operation, this includes the splatting behavior when mixing scalar and vector operands, which was done for binary operations but not for compound assignments.
Closes #2048