Skip to content
This repository was archived by the owner on Jan 29, 2025. It is now read-only.

Add a helper for getting the location of a span in some textual source #1937

Merged
merged 2 commits into from
May 26, 2022

Conversation

nical
Copy link
Contributor

@nical nical commented May 23, 2022

The idea is to get an easily consumable location (line/column/etc.) in the shader source for errors, where "easily consumable" really just means what the WebGPU spec expects for errors.

r? @jimblandy

@jimblandy jimblandy self-requested a review May 25, 2022 23:21
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just tweaked the docs a bit.

@jimblandy jimblandy enabled auto-merge (rebase) May 26, 2022 00:12
@jimblandy jimblandy merged commit f035854 into gfx-rs:master May 26, 2022
@nical nical deleted the span-location branch June 6, 2022 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants