Skip to content
This repository was archived by the owner on Jan 29, 2025. It is now read-only.

Add error for matrices without f32 scalar type #1917

Merged
merged 1 commit into from
May 14, 2022

Conversation

grovesNL
Copy link
Collaborator

Fixes #1896

@grovesNL grovesNL force-pushed the non-floating-matrix branch 2 times, most recently from 5e45fbe to 3fe9697 Compare May 14, 2022 02:49
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, left a few comments.

@grovesNL grovesNL force-pushed the non-floating-matrix branch from 3fe9697 to 39c857d Compare May 14, 2022 13:32
@grovesNL
Copy link
Collaborator Author

Thank you! Updated the PR

@grovesNL grovesNL force-pushed the non-floating-matrix branch from 39c857d to 23a0f52 Compare May 14, 2022 14:55
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@teoxoy teoxoy merged commit 60ae549 into gfx-rs:master May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wgsl-in] Error on matrices with non float scalar kinds
2 participants