Skip to content
This repository was archived by the owner on Jan 29, 2025. It is now read-only.

Remove named expression entry for phony assignment #1869

Merged
merged 1 commit into from
May 10, 2022

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Apr 28, 2022

Follow up to #1866 (comment)

@teoxoy
Copy link
Member Author

teoxoy commented Apr 28, 2022

The GLSL frontend is generating some extra expressions that end up being emitted as phony assignments.
I tried to look into it without much success; @JCapucho do you have any pointers to what might be the cause?

@JCapucho
Copy link
Collaborator

The glsl frontend generates a lot of expressions that aren't needed because it's generally easier to do it that way than to add them as needed later, but I do see some weird ones there that I'll need to check out.

@teoxoy teoxoy force-pushed the phony-not-named-expr branch from 0e88c5b to 859cbac Compare May 2, 2022 08:59
@teoxoy teoxoy force-pushed the phony-not-named-expr branch from 859cbac to be32dcf Compare May 10, 2022 08:38
@teoxoy teoxoy merged commit ceb9292 into gfx-rs:master May 10, 2022
@teoxoy teoxoy deleted the phony-not-named-expr branch May 10, 2022 08:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants