This repository was archived by the owner on Jan 29, 2025. It is now read-only.
glsl-in: matrix operations fixes #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
Mar 3, 2022
| || left_rows != right_rows | ||
| || left_width != right_width | ||
| { | ||
| parser.errors.push(Error { |
There was a problem hiding this comment.
is this check necessary? general validation would produce a very similar error, I think
There was a problem hiding this comment.
Checking the width and the rows is not necessary, but the columns need to be checked since otherwise code that uses matrices with different columns would either fail on validation or truncate depending on the order.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains multiple fixes for matrix related binary operations:
Closes #1408
All commits can be reviewed and tested individually