This repository was archived by the owner on Jan 29, 2025. It is now read-only.
glsl-in: Add support for texelFetchOffset #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
reviewed
Feb 25, 2022
| @@ -322,7 +323,7 @@ pub fn inject_builtin( | |||
| let dim_value = image_dims_to_coords_size(dim); | |||
| let coordinates = make_coords_arg(dim_value + arrayed as usize, Sk::Sint); | |||
|
|
|||
| let args = vec
|
We should probably run Clippy on MSRV only, so that it's predictable. |
JCapucho
force-pushed
the
glsl-texelFetchOffset
branch
from
58fb789 to
0d2c03d
Compare
|
@kvark sorry for the late response, was out of town for a while, jim seems to have already fixed the clippy lint but it might still be a good idea to change the pipeline to use the MSRV or the latest stable (and maybe have another optional pipeline for checking on nightly), I can implement it if you want, just wanted to hear your thoughts on the matter. |
JCapucho
force-pushed
the
glsl-texelFetchOffset
branch
from
0d2c03d to
d4a261f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.