This repository was archived by the owner on Jan 29, 2025. It is now read-only.

glsl-out: Write correct argument name when skipping samplers #1671

Merged

kvark merged 1 commit into gfx-rs:master from JCapucho:glsl-out-names

Jan 16, 2022

Collaborator

JCapucho commented Jan 15, 2022

Previously the name of the sampler would be picked for the next argument, this is bad for two reasons:

The debug data would be wrong
If the argument was a pointer and written to, the expression would pick the right name but there wouldn't be a argument with that name


          glsl-out: Write correct argument name when skipping samplers

a90a4af

kvark approved these changes

View reviewed changes

kvark added the can backport label

kvark merged commit b42bf87 into gfx-rs:master

kvark mentioned this pull request

Release 0.8.3 #1678

Merged

kvark removed the can backport label

Member

kvark commented Jan 21, 2022

published in 0.8.3

JCapucho deleted the glsl-out-names branch

February 19, 2022 15:11

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet