This repository was archived by the owner on Jan 29, 2025. It is now read-only.
[hlsl-out] Fix reading from mat3 #1199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs to be included in the PR |
kvark
approved these changes
Aug 16, 2021
cwfitzgerald
force-pushed
the
hlsl-out-mat3
branch
2 times, most recently
from
63ad298 to
b7828f3
Compare
kvark
reviewed
Aug 17, 2021
cwfitzgerald
force-pushed
the
hlsl-out-mat3
branch
from
b7828f3 to
b842849
Compare
kvark
approved these changes
Aug 17, 2021
|
CI is sad, and I asked a small question about the semantics of matrix * matrix on the matrix (d'oh!) |
cwfitzgerald
force-pushed
the
hlsl-out-mat3
branch
from
b842849 to
2c56c35
Compare
kvark
approved these changes
Aug 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one part of the issues I'm having with rend3. This now matches the behavior of vulkan exactly.