ocikms: Oracle Cloud KMS support #1226
Conversation
Makefile
Outdated
| @@ -36,7 +36,7 @@ generate: keyservice/keyservice.pb.go | |||
| $(GO) generate | |||
|
|
|||
| %.pb.go: %.proto | |||
| protoc --go_out=plugins=grpc:. $< | |||
| protoc --go_out=. --go-grpc_out=require_unimplemented_servers=false:. $< | |||
There was a problem hiding this comment.
This should be the current way of generating files with protoc since 1.20 I believe.
The generated files are also split now as you can see below.
The flag require_unimplemented_servers=false is necessary to preserve the previous functionality.
Please note that I am using:
I have also tried
protoc-gen-go v1.23.0
protoc v3.13.0
but I am still getting errors with the plugin settings.
I don't think this is an issue but just flagging for the reviewer
keyservice/keyservice.proto
Outdated
| @@ -1,5 +1,7 @@ | |||
| syntax = "proto3"; | |||
|
|
|||
| option go_package = "/keyservice"; | |||
There was a problem hiding this comment.
Added this ad best practice and because I was getting errors because of this as well when doing make generate
Signed-off-by: Alessandro De Blasis <[email protected]>
deblasis
force-pushed
the
issue/#981-oci-kms
branch
from
95a366b to
34d2349
Compare
Signed-off-by: Alessandro De Blasis <[email protected]>
…oci-kms Signed-off-by: Alessandro De Blasis <[email protected]>
deblasis
force-pushed
the
issue/#981-oci-kms
branch
from
3fa4e3c to
6407abc
Compare
|
Is there anything else blocking this PR from being merged main for the 3.10.0 milestone release? is there an ETA on 3.10.0? |
|
I personally won't have time to review this anytime soon (see #1097 (comment)). I'm not sure if anyone else from the maintainers has time either, but it might well be that this won't make it into 3.10 and will get moved to the 3.11 milestone (once that exists). |
Hi there, I found myself needing this so I thought it was a good opportunity to contribute a little.
Happy to make the necessary changes, I tried to comply with style as much as possible.
Fixes #981
cc: @colemickens, @davidpinhas, @b-dean
Basic Demo
sops_oci_kms_demo.mp4