fix(overlay): Fix eager profile grafting on incomplete trace data #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a race condition where we try to graft a trace which was a skeleton generated from a trace context rather than a full trace. This was causing profile frames not getting grafted as the start_timestamp and timestamp values were not set correctly.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #783 +/- ##
==========================================
- Coverage 32.81% 32.79% -0.03%
==========================================
Files 93 93
Lines 5838 5839 +1
Branches 118 118
==========================================
- Hits 1916 1915 -1
- Misses 3922 3924 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BYK
pushed a commit
that referenced
this pull request
Apr 22, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/[email protected] ### Patch Changes - Updated dependencies \[]: - @spotlightjs/[email protected] ## @spotlightjs/[email protected] ### Patch Changes - Updated dependencies \[[`893572a959d94aae2dce2b49e91d43ea649233fa`](893572a)]: - @spotlightjs/[email protected] ## @spotlightjs/[email protected] ### Patch Changes - Fixes a race condition where we try to graft a trace which was a skeleton generated from a trace context rather than a ([#783](#783)) full trace. This was causing profile frames not getting grafted as the start_timestamp and timestamp values were not set correctly. ## @spotlightjs/[email protected] ### Patch Changes - Updated dependencies \[[`893572a959d94aae2dce2b49e91d43ea649233fa`](893572a)]: - @spotlightjs/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition where we try to graft a trace which was a skeleton generated from a trace context rather than a full trace. This was causing profile frames not getting grafted as the start_timestamp and timestamp values were not set correctly.