fix: Fix logic in span detail back #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Fixes the inversed logic from #701
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
=======================================
Coverage 31.96% 31.96%
=======================================
Files 92 92
Lines 5834 5834
Branches 118 118
=======================================
Hits 1865 1865
Misses 3969 3969 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BYK
pushed a commit
that referenced
this pull request
Mar 13, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/[email protected] ### Minor Changes - Make event id a link to raw envelope on envelope details page ([#729](#729)) ### Patch Changes - Fix envelope sorting and local classification ([#727](#727)) - Fix UI issues when we get a bare span envelope ([#726](#726)) - Fix span details modal resetting trace view tree state on close (for reals this time) ([#728](#728)) - Fixes detection of Sentry SDK frames in Vite projects ([#718](#718)) - Updated dependencies \[[`9ca9ed1b97119757d8b1ec6de24d781aefe8b76c`](9ca9ed1), [`c39cfb3622fe19ccc5df822d30d16298f254cb17`](c39cfb3), [`f731d9171ead5aea21152f1d3bfa89e473a7272c`](f731d91), [`97dfa768846c76da47521f551b1bb45c683a23d9`](97dfa76), [`79506149f545487e67cdff7eab7393c619c8afd9`](7950614)]: - @spotlightjs/[email protected] ## @spotlightjs/[email protected] ### Minor Changes - Make event id a link to raw envelope on envelope details page ([#729](#729)) ### Patch Changes - Fix envelope sorting and local classification ([#727](#727)) - Fix UI issues when we get a bare span envelope ([#726](#726)) - Fix span details modal resetting trace view tree state on close (for reals this time) ([#728](#728)) - Fixes detection of Sentry SDK frames in Vite projects ([#718](#718)) - Updated dependencies \[[`9ca9ed1b97119757d8b1ec6de24d781aefe8b76c`](9ca9ed1), [`c39cfb3622fe19ccc5df822d30d16298f254cb17`](c39cfb3), [`f731d9171ead5aea21152f1d3bfa89e473a7272c`](f731d91), [`97dfa768846c76da47521f551b1bb45c683a23d9`](97dfa76), [`448062fd45799832fc3240656d543696d438d5ab`](448062f), [`79506149f545487e67cdff7eab7393c619c8afd9`](7950614)]: - @spotlightjs/[email protected] ## @spotlightjs/[email protected] ### Minor Changes - Make event id a link to raw envelope on envelope details page ([#729](#729)) - Added Search support in Trace details ([#730](#730)) ### Patch Changes - Fix envelope sorting and local classification ([#727](#727)) - Fix UI issues when we get a bare span envelope ([#726](#726)) - Fix span details modal resetting trace view tree state on close (for reals this time) ([#728](#728)) - Fixes detection of Sentry SDK frames in Vite projects ([#718](#718)) ## @spotlightjs/[email protected] ### Minor Changes - Make event id a link to raw envelope on envelope details page ([#729](#729)) ### Patch Changes - Fix envelope sorting and local classification ([#727](#727)) - Fix UI issues when we get a bare span envelope ([#726](#726)) - Fix span details modal resetting trace view tree state on close (for reals this time) ([#728](#728)) - Fixes detection of Sentry SDK frames in Vite projects ([#718](#718)) - Updated dependencies \[[`9ca9ed1b97119757d8b1ec6de24d781aefe8b76c`](9ca9ed1), [`c39cfb3622fe19ccc5df822d30d16298f254cb17`](c39cfb3), [`f731d9171ead5aea21152f1d3bfa89e473a7272c`](f731d91), [`97dfa768846c76da47521f551b1bb45c683a23d9`](97dfa76), [`448062fd45799832fc3240656d543696d438d5ab`](448062f), [`79506149f545487e67cdff7eab7393c619c8afd9`](7950614)]: - @spotlightjs/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the inversed logic from #701